Repository navigation
Change default header representation to bytes. - #502
Merged
Merged
Conversation
This change kinda semi-randomly swaps some tests to use the new default behaviour, and has some opt-in to the old behaviour, to ensure that both continue to work
alexwlchan
approved these changes
Mar 24, 2017
alexwlchan
left a comment
alexwlchan
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
That was surprisingly un-horrible a patch, given that encodings are usually a bit of a quagmire. 😄
Member
Author
|
Yeah, handily when we had to solve this the first time (to allow bytes through) almost all the problems went away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #154.
After this, we're very close to being ready to go for 3.0.